Bug 80403

Summary: [Forms] Hidden input element should not have labels.
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, morrita, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://jsfiddle.net/56yRM/
Bug Depends on: 80392, 80574    
Bug Blocks:    
Attachments:
Description Flags
Patch 1
none
Patch 2
none
Patch 3 none

yosin
Reported 2012-03-06 02:37:54 PST
According to the specification[1], "hidden" input type element isn't labelable. * FF=PASS * IE=PASS * OP=FAIL Sample URI(http://jsfiddle.net/56yRM/) should output only "Hidden". [1] http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#category-label
Attachments
Patch 1 (5.78 KB, patch)
2012-03-07 21:28 PST, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (13.05 KB, patch)
2012-03-13 01:01 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 3 (14.72 KB, patch)
2012-03-13 22:04 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-03-07 21:28:38 PST
Created attachment 130763 [details] Patch 1
yosin
Comment 2 2012-03-13 01:01:58 PDT
Created attachment 131570 [details] Patch 2
Kent Tamura
Comment 3 2012-03-13 21:24:28 PDT
Comment on attachment 131570 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=131570&action=review > Source/WebCore/ChangeLog:12 > + Note: The HTML5 specification isn't clear for non-labelable element's "labels" > + attribute return value. FF and OP return empty node list. IE returns null. nit: 'FF' 'OP' are not so common abbreviations. > LayoutTests/fast/forms/label/labelable-elements-expected.txt:84 > -FAIL element.labels should be undefined. Was [object NodeList] > -PASS element.labels is not null > +PASS element.labels is null We need similar changes for LayoutTests/platform/*/fast/forms/label/labelable-elements-expected.txt.
yosin
Comment 4 2012-03-13 22:04:04 PDT
Created attachment 131785 [details] Patch 3
Kent Tamura
Comment 5 2012-03-13 22:06:11 PDT
Comment on attachment 131785 [details] Patch 3 ok
WebKit Review Bot
Comment 6 2012-03-13 23:54:20 PDT
Comment on attachment 131785 [details] Patch 3 Clearing flags on attachment: 131785 Committed r110665: <http://trac.webkit.org/changeset/110665>
WebKit Review Bot
Comment 7 2012-03-13 23:54:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.