Bug 80712

Summary: [CSS Regions] Convert some fast/regions pixel tests to reftests
Product: WebKit Reporter: David Alcala <dalcala>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, kling, mibalan, mihnea, rakuco, rhauck, stavila, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63344    
Attachments:
Description Flags
Patch
none
Patch
achicu: review-
Patch none

David Alcala
Reported 2012-03-09 11:07:46 PST
Convert the fast/regions/webkit-flow* pixel tests to reftests
Attachments
Patch (36.92 KB, patch)
2013-04-29 07:05 PDT, Radu Stavila 		no flags
DetailsFormatted DiffDiff
Patch (308.08 KB, patch)
2013-04-29 07:11 PDT, Radu Stavila 		achicu: review-
DetailsFormatted DiffDiff
Patch (308.51 KB, patch)
2013-04-30 03:49 PDT, Radu Stavila 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radu Stavila
Comment 1 2013-04-29 07:05:30 PDT
Created attachment 200003 [details] Patch
Radu Stavila
Comment 2 2013-04-29 07:11:49 PDT
Created attachment 200005 [details] Patch
Alexandru Chiculita
Comment 3 2013-04-29 09:24:08 PDT
Comment on attachment 200005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200005&action=review Thanks, looks good! I have a couple of hints below. The comments apply for both html files. > LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.html:5 > + text-align: justify; nit: you have different indentation styles in the style elements. > LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.html:87 > + margin-top: -22px; <p> tags have margin-top/bottom set using "em" units. I think you could avoid using <p> tags or set the margins to 0 to avoid having to compensate for it in the parent box. Setting the margin this way makes the ref-test fragile when changing the default font-size.
Radu Stavila
Comment 4 2013-04-30 03:49:12 PDT
Created attachment 200097 [details] Patch Made recommended changes
Radu Stavila
Comment 5 2013-04-30 08:26:26 PDT
Remaining tests will be tracked in https://bugs.webkit.org/show_bug.cgi?id=115422
Alexandru Chiculita
Comment 6 2013-04-30 09:26:34 PDT
Comment on attachment 200097 [details] Patch Looks better. R=me You need to set the CQ? flag if you want the reviewer to set the CQ+ flag.
WebKit Commit Bot
Comment 7 2013-04-30 09:56:31 PDT
Comment on attachment 200097 [details] Patch Clearing flags on attachment: 200097 Committed r149374: <http://trac.webkit.org/changeset/149374>
WebKit Commit Bot
Comment 8 2013-04-30 09:56:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.