Bug 81867

Summary: [BlackBerry] Add HistoryItemViewState for BlackBerry port
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: WebKit BlackBerryAssignee: Leo Yang <leo.yang>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, rwlbuis, staikos, tonikitoo, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch
none
Patch v2
rwlbuis: review+
Patch for landing
leo.yang: commit-queue-
Patch for landing none

Leo Yang
Reported 2012-03-21 20:36:59 PDT
HistoryItemViewState is the balckberry specific field of HistoryItem.
Attachments
Patch (2.73 KB, patch)
2012-03-21 20:41 PDT, Leo Yang 		no flags
DetailsFormatted DiffDiff
Patch v2 (2.71 KB, patch)
2012-03-21 21:22 PDT, Leo Yang 		rwlbuis: review+
DetailsFormatted DiffDiff
Patch for landing (2.70 KB, patch)
2012-03-22 18:49 PDT, Leo Yang 		leo.yang: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (2.70 KB, patch)
2012-03-22 18:56 PDT, Leo Yang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Leo Yang
Comment 1 2012-03-21 20:41:29 PDT
Created attachment 133179 [details] Patch
Charles Wei
Comment 2 2012-03-21 20:46:54 PDT
Comment on attachment 133179 [details] Patch Looks good to me, this is blackberry-specific view state in the history. Need a webkit reviewer to approve this though.
Leo Yang
Comment 3 2012-03-21 20:58:49 PDT
Comment on attachment 133179 [details] Patch Let's remove const and mutable ...
Leo Yang
Comment 4 2012-03-21 21:22:59 PDT
Created attachment 133182 [details] Patch v2
Rob Buis
Comment 5 2012-03-22 04:32:09 PDT
Comment on attachment 133182 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=133182&action=review LGTM. > Source/WebCore/ChangeLog:8 > + HistoryItemViewState is the balckberry specific field of HistoryItem. typo: balckberry
Leo Yang
Comment 6 2012-03-22 18:49:29 PDT
Created attachment 133408 [details] Patch for landing
Leo Yang
Comment 7 2012-03-22 18:53:35 PDT
Comment on attachment 133408 [details] Patch for landing Holding
Leo Yang
Comment 8 2012-03-22 18:56:13 PDT
Created attachment 133410 [details] Patch for landing
WebKit Review Bot
Comment 9 2012-03-22 20:20:57 PDT
Comment on attachment 133410 [details] Patch for landing Clearing flags on attachment: 133410 Committed r111819: <http://trac.webkit.org/changeset/111819>
WebKit Review Bot
Comment 10 2012-03-22 20:21:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.