Bug 82658

Created attachment 140540 [details] Patch

Attachment 140540 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1 WebKitLibraries/WebKitSystemInterface.h:492: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 140540 [details] Patch Attachment 140540 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12643373

Created attachment 140597 [details] Patch

Comment on attachment 140597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140597&action=review > Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp:154 > +#if (USE(CFNETWORK) && !PLATFORM(WIN)) || (PLATFORM(MAC) && !defined(BUILDING_ON_SNOW_LEOPARD)) This whole file is already wrapped in #if USE(CFNETWORK), so there’s no reason to check that. The part of the predicate after the || is pointless because if !PLATFORM(WIN) is true then it won’t even be evaluated.

Committed r116473: <http://trac.webkit.org/changeset/116473>

Newly added test http/tests/loading/post-in-iframe-with-back-navigation fails on bots. SnowLeopard Intel Release (Tests): --- /Volumes/Data/slave/snowleopard-intel-release-tests/build/layout-test-results/http/tests/loading/post-in-iframe-with-back-navigation-expected.txt +++ /Volumes/Data/slave/snowleopard-intel-release-tests/build/layout-test-results/http/tests/loading/post-in-iframe-with-back-navigation-actual.txt @@ -2,12 +2,12 @@ main frame - didCommitLoadForFrame main frame - didReceiveTitle: Resending form on back navigation from POST submissions frame "frame" - didStartProvisionalLoadForFrame +main frame - didFinishDocumentLoadForFrame frame "frame" - didCommitLoadForFrame frame "frame" - didFinishDocumentLoadForFrame frame "frame" - didHandleOnloadEventsForFrame +main frame - didHandleOnloadEventsForFrame frame "frame" - didFinishLoadForFrame -main frame - didFinishDocumentLoadForFrame -main frame - didHandleOnloadEventsForFrame main frame - didFinishLoadForFrame frame "frame" - willPerformClientRedirectToURL: http://127.0.0.1:8000/loading/resources/post-in-iframe-with-back-navigation-page-2.php frame "frame" - didStartProvisionalLoadForFrame @@ -40,5 +40,5 @@ PASS getTitle() is "Page 2" PASS getTitle() is "Page 3" PASS getTitle() is "Page 2" -PASS window.frames[0].document.getElementById('submissionTime').innerText is step2output +FAIL window.frames[0].document.getElementById('submissionTime').innerText should be 0.90880500 1336551470. Was 0.92378600 1336551470. Lion Release (Tests): --- /Volumes/Data/slave/lion-intel-release-tests/build/layout-test-results/http/tests/loading/post-in-iframe-with-back-navigation-expected.txt +++ /Volumes/Data/slave/lion-intel-release-tests/build/layout-test-results/http/tests/loading/post-in-iframe-with-back-navigation-actual.txt @@ -40,5 +40,5 @@ PASS getTitle() is "Page 2" PASS getTitle() is "Page 3" PASS getTitle() is "Page 2" -PASS window.frames[0].document.getElementById('submissionTime').innerText is step2output +FAIL window.frames[0].document.getElementById('submissionTime').innerText should be 0.21158600 1336551059. Was 0.22550900 1336551059. GTK Linux 64-bit Release: --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/http/tests/loading/post-in-iframe-with-back-navigation-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/http/tests/loading/post-in-iframe-with-back-navigation-actual.txt @@ -1,28 +1,13 @@ main frame - didStartProvisionalLoadForFrame main frame - didCommitLoadForFrame -main frame - didReceiveTitle: Resending form on back navigation from POST submissions frame "frame" - didStartProvisionalLoadForFrame +main frame - didFinishDocumentLoadForFrame frame "frame" - didCommitLoadForFrame frame "frame" - didFinishDocumentLoadForFrame frame "frame" - didHandleOnloadEventsForFrame +main frame - didHandleOnloadEventsForFrame frame "frame" - didFinishLoadForFrame -main frame - didFinishDocumentLoadForFrame -main frame - didHandleOnloadEventsForFrame main frame - didFinishLoadForFrame -frame "frame" - willPerformClientRedirectToURL: http://127.0.0.1:8000/loading/resources/post-in-iframe-with-back-navigation-page-2.php -frame "frame" - didStartProvisionalLoadForFrame -frame "frame" - didCancelClientRedirectForFrame -frame "frame" - didCommitLoadForFrame -frame "frame" - didFinishDocumentLoadForFrame -frame "frame" - didHandleOnloadEventsForFrame -frame "frame" - didFinishLoadForFrame -frame "frame" - willPerformClientRedirectToURL: http://127.0.0.1:8000/loading/resources/post-in-iframe-with-back-navigation-page-3.php -frame "frame" - didStartProvisionalLoadForFrame -frame "frame" - didCancelClientRedirectForFrame -frame "frame" - didCommitLoadForFrame -frame "frame" - didFinishDocumentLoadForFrame -frame "frame" - didHandleOnloadEventsForFrame -frame "frame" - didFinishLoadForFrame frame "frame" - didStartProvisionalLoadForFrame frame "frame" - didCommitLoadForFrame frame "frame" - didFinishDocumentLoadForFrame @@ -38,7 +23,4 @@ TEST COMPLETE PASS getTitle() is "Page 1" PASS getTitle() is "Page 2" -PASS getTitle() is "Page 3" -PASS getTitle() is "Page 2" -PASS window.frames[0].document.getElementById('submissionTime').innerText is step2output Qt Linux Release: --- /ramdisk/qt-linux-release/build/layout-test-results/http/tests/loading/post-in-iframe-with-back-navigation-expected.txt +++ /ramdisk/qt-linux-release/build/layout-test-results/http/tests/loading/post-in-iframe-with-back-navigation-actual.txt @@ -2,12 +2,12 @@ main frame - didCommitLoadForFrame main frame - didReceiveTitle: Resending form on back navigation from POST submissions frame "frame" - didStartProvisionalLoadForFrame +main frame - didFinishDocumentLoadForFrame frame "frame" - didCommitLoadForFrame frame "frame" - didFinishDocumentLoadForFrame frame "frame" - didHandleOnloadEventsForFrame +main frame - didHandleOnloadEventsForFrame frame "frame" - didFinishLoadForFrame -main frame - didFinishDocumentLoadForFrame -main frame - didHandleOnloadEventsForFrame main frame - didFinishLoadForFrame frame "frame" - willPerformClientRedirectToURL: http://127.0.0.1:8000/loading/resources/post-in-iframe-with-back-navigation-page-2.php frame "frame" - didStartProvisionalLoadForFrame @@ -40,5 +40,5 @@ PASS getTitle() is "Page 2" PASS getTitle() is "Page 3" PASS getTitle() is "Page 2" -PASS window.frames[0].document.getElementById('submissionTime').innerText is step2output +FAIL window.frames[0].document.getElementById('submissionTime').innerText should be 0.74495000 1336551371. Was 0.75300800 1336551371.

New bug on this fail: https://bugs.webkit.org/show_bug.cgi?id=85969

This broke build. From http://build.webkit.org/builders/Lion%20Debug%20%28Build%29/builds/9762/steps/compile-webkit/logs/stdio /Volumes/Data/slave/lion-intel-debug/build/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm:188:5: error: use of undeclared identifier 'WKCFURLRequestAllowAllPostCaching'; did you mean 'wkCFURLRequestAllowAllPostCaching'? [3] INIT(CFURLRequestAllowAllPostCaching); ^ /Volumes/Data/slave/lion-intel-debug/build/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm:37:41: note: instantiated from: #define INIT(function) wk##function = WK##function ^ <scratch space>:88:1: note: instantiated from: WKCFURLRequestAllowAllPostCaching ^ /Volumes/Data/slave/lion-intel-debug/build/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/WebCoreSystemInterface.h:327:15: note: 'wkCFURLRequestAllowAllPostCaching' declared here [3] extern void (*wkCFURLRequestAllowAllPostCaching)(CFURLRequestRef); ^ 1 error generated.

Apparently it started building.