Bug 85272

Summary: Calendar Picker: Add capability to add platform-specific style sheet
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 53961    
Attachments:
Description Flags
Patch none

Kent Tamura
Reported 2012-05-01 03:11:42 PDT
Calendar Picker: Add capability to add platform-specific style sheet
Attachments
Patch (11.63 KB, patch)
2012-05-01 03:22 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-05-01 03:22:55 PDT
Created attachment 139604 [details] Patch
Kentaro Hara
Comment 2 2012-05-01 09:12:14 PDT
Comment on attachment 139604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139604&action=review > Source/WebCore/Resources/calendarPicker.css:-99 > -/* FIXME: We'd like to use the standard button appearance for non-Mac. */ Just a confirmation: Is it OK to remove the following css? I mean, aren't other platforms using .year-month-button in calendarPicker.css? > Source/WebCore/Resources/calendarPickerMac.css:31 > +.year-month-button { Just a confirmation: calendarPickerMac.css does not have .year-month-button:hover, which had existed in calendarPicker.css. Is it intentional?
Kent Tamura
Comment 3 2012-05-01 16:38:58 PDT
Comment on attachment 139604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139604&action=review >> Source/WebCore/Resources/calendarPicker.css:-99 >> -/* FIXME: We'd like to use the standard button appearance for non-Mac. */ > > Just a confirmation: Is it OK to remove the following css? I mean, aren't other platforms using .year-month-button in calendarPicker.css? The year-month-button class is added to <input type=button>. Non-Mac platforms use the standard appearance of <input type=button>. >> Source/WebCore/Resources/calendarPickerMac.css:31 >> +.year-month-button { > > Just a confirmation: calendarPickerMac.css does not have .year-month-button:hover, which had existed in calendarPicker.css. Is it intentional? Yes, it's intentional. In general, OS X needs no :hover style for buttons and Windows needs it. Before this patch, we applied year-month-button style to buttons in all platforms, and it was aligned to Windows-style. The :hover rule is not needed for this file because this files is for OS X.
Kentaro Hara
Comment 4 2012-05-01 16:40:37 PDT
Comment on attachment 139604 [details] Patch Makes sense. r+ for the C++ part and rs for the css part.
Kent Tamura
Comment 5 2012-05-01 16:45:30 PDT
Comment on attachment 139604 [details] Patch thanks!
WebKit Review Bot
Comment 6 2012-05-01 17:12:04 PDT
Comment on attachment 139604 [details] Patch Clearing flags on attachment: 139604 Committed r115764: <http://trac.webkit.org/changeset/115764>
WebKit Review Bot
Comment 7 2012-05-01 17:12:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.