Bug 87470

Summary: An event re-targeting algorithm does not set event's target correctly for multiple shadow roots.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: UI EventsAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, morrita, shinyak, tasak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 59805    
Attachments:
Description Flags
fix an event re-target to support multiple shadow roots
none
Archive of layout-test-results from ec2-cr-linux-04
none
fix svg errors
none
Patch for landing none

Hayato Ito
Reported 2012-05-25 01:11:27 PDT
The current implementation (WebCore::EventDispatcher::ensureEventAncestors) does not set event's target correctly if it is applied to multiple shadow roots. Let me upload a test case and a fix soon.
Attachments
fix an event re-target to support multiple shadow roots (8.17 KB, patch)
2012-05-25 02:31 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-04 (671.45 KB, application/zip)
2012-05-25 03:12 PDT, WebKit Review Bot 		no flags
Details
fix svg errors (8.15 KB, patch)
2012-05-25 03:28 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.17 KB, patch)
2012-05-27 20:15 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2012-05-25 02:31:54 PDT
Created attachment 144014 [details] fix an event re-target to support multiple shadow roots
Hayato Ito
Comment 2 2012-05-25 02:35:29 PDT
I feed bad that shadow-dom-event-dispatching.html has badly-named functions. It has functions from 'prepareDOMTree1' to 'prepareDOMTree8'... I filed that as another bug. https://bugs.webkit.org/show_bug.cgi?id=87477 I also think that current shadow DOM spec should be slightly modified. Let me file it later.
Hayato Ito
Comment 3 2012-05-25 02:53:49 PDT
I filed a bug for the spec: https://www.w3.org/Bugs/Public/show_bug.cgi?id=17177 (In reply to comment #2) > I feed bad that shadow-dom-event-dispatching.html has badly-named functions. > It has functions from 'prepareDOMTree1' to 'prepareDOMTree8'... > > I filed that as another bug. https://bugs.webkit.org/show_bug.cgi?id=87477 > > I also think that current shadow DOM spec should be slightly modified. Let me file it later.
WebKit Review Bot
Comment 4 2012-05-25 03:12:21 PDT
Comment on attachment 144014 [details] fix an event re-target to support multiple shadow roots Attachment 144014 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12791482 New failing tests: svg/custom/use-elementInstance-methods.svg svg/custom/use-elementInstance-event-target.svg svg/custom/use-instanceRoot-as-event-target.xhtml svg/custom/use-instanceRoot-event-bubbling.xhtml
WebKit Review Bot
Comment 5 2012-05-25 03:12:25 PDT
Created attachment 144026 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Hayato Ito
Comment 6 2012-05-25 03:28:54 PDT
Created attachment 144030 [details] fix svg errors
Dimitri Glazkov (Google)
Comment 7 2012-05-25 08:25:58 PDT
Comment on attachment 144030 [details] fix svg errors Good catch and much cleaner resulting code. Please consider adding anime to your tests.
Hayato Ito
Comment 8 2012-05-27 19:49:07 PDT
Thank you for the review. (In reply to comment #7) > (From update of attachment 144030 [details]) > Good catch and much cleaner resulting code. Please consider adding anime to your tests. It's more difficult for me to add anime characters than to fix crash bugs. Any suggestions for anime characters are highly welcome.
WebKit Review Bot
Comment 9 2012-05-27 19:51:01 PDT
Comment on attachment 144030 [details] fix svg errors Rejecting attachment 144030 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12850037
Hayato Ito
Comment 10 2012-05-27 20:15:52 PDT
Created attachment 144259 [details] Patch for landing
WebKit Review Bot
Comment 11 2012-05-27 21:39:48 PDT
Comment on attachment 144259 [details] Patch for landing Clearing flags on attachment: 144259 Committed r118645: <http://trac.webkit.org/changeset/118645>
WebKit Review Bot
Comment 12 2012-05-27 21:39:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.