Bug 88251

Summary: Some shadow roots are not showing up in Inspector
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, hayato, komoroske, morrita, pfeldman, shinyak, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://jsfiddle.net/dglazkov/b8QXN/
Bug Depends on:    
Bug Blocks: 72352, 62220    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Dimitri Glazkov (Google)
Reported 2012-06-04 13:09:42 PDT
To repro: 1) Turn on shadow DOM inspecton 2) Go to http://jsfiddle.net/dglazkov/b8QXN/ 3) Inspect the "Result" pane and look for shadow roots You'll find that only the first shadow root is showing.
Attachments
Patch (6.34 KB, patch)
2012-09-27 06:40 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (6.33 KB, patch)
2012-10-08 18:47 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (6.35 KB, patch)
2012-10-11 03:38 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.24 KB, patch)
2012-10-11 05:18 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-09-25 23:19:10 PDT
it seems elements having no children (except text) does not show shadow roots, since they will not have any triangle marker by default. I'm preparing a patch for this. This bug is very annoying when debugging ShadowDOM related stuffs, so I would like to fix as soon as possible.
Shinya Kawanaka
Comment 2 2012-09-25 23:56:02 PDT
Ah, an element having no children is wrong, an element having only text is correct.
Shinya Kawanaka
Comment 3 2012-09-27 06:40:56 PDT
Created attachment 165991 [details] Patch
Shinya Kawanaka
Comment 4 2012-10-08 18:47:17 PDT
Created attachment 167668 [details] Patch
Build Bot
Comment 5 2012-10-08 19:36:55 PDT
Comment on attachment 167668 [details] Patch Attachment 167668 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14228460 New failing tests: inspector/elements/shadow-dom-modify-chardata.html inspector/elements/edit-dom-actions.html inspector/elements/elements-panel-search.html inspector/elements/shadow-root.html inspector/elements/elements-panel-reload-assert.html inspector/console/console-format-collections.html
WebKit Review Bot
Comment 6 2012-10-08 20:23:40 PDT
Comment on attachment 167668 [details] Patch Attachment 167668 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14221516 New failing tests: inspector/elements/elements-panel-search.html inspector/elements/shadow-dom-modify-chardata.html inspector/elements/elements-panel-reload-assert.html inspector/elements/shadow-root.html inspector/elements/edit-dom-actions.html
Shinya Kawanaka
Comment 7 2012-10-09 01:55:34 PDT
Ohya
Pavel Feldman
Comment 8 2012-10-10 00:33:25 PDT
Comment on attachment 167668 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167668&action=review > Source/WebCore/inspector/front-end/DOMAgent.js:70 > + if (payload.shadowRoots && WebInspector.experimentsSettings.showShadowDOM.isEnabled()) { Experiments? It sounds like a poor merge.
Shinya Kawanaka
Comment 9 2012-10-11 03:38:44 PDT
Created attachment 168187 [details] Patch
Pavel Feldman
Comment 10 2012-10-11 04:20:34 PDT
Comment on attachment 168187 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168187&action=review > LayoutTests/inspector/elements/shadow-root.html:21 > + // For insurance. We never do such things. Let the test timeout instead.
Shinya Kawanaka
Comment 11 2012-10-11 05:18:39 PDT
Created attachment 168198 [details] Patch for landing
WebKit Review Bot
Comment 12 2012-10-11 05:49:47 PDT
Comment on attachment 168198 [details] Patch for landing Clearing flags on attachment: 168198 Committed r131046: <http://trac.webkit.org/changeset/131046>
WebKit Review Bot
Comment 13 2012-10-11 05:49:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.