Bug 92359

Summary: Web Inspector: move StringImpl size calculation to StringImpl
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 92379    
Attachments:
Description Flags
Patch
none
Patch
buildbot: commit-queue-
Patch for landing none

Yury Semikhatsky
Reported 2012-07-26 03:07:33 PDT
It is now implemented in InspectorMemoryAgent.
Attachments
Patch (5.05 KB, patch)
2012-07-26 03:20 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (5.08 KB, patch)
2012-07-26 03:21 PDT, Yury Semikhatsky 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (4.74 KB, patch)
2012-07-30 01:09 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-07-26 03:20:04 PDT
Created attachment 154600 [details] Patch
Yury Semikhatsky
Comment 2 2012-07-26 03:21:36 PDT
Created attachment 154601 [details] Patch
WebKit Review Bot
Comment 3 2012-07-26 06:18:14 PDT
Comment on attachment 154601 [details] Patch Clearing flags on attachment: 154601 Committed r123740: <http://trac.webkit.org/changeset/123740>
WebKit Review Bot
Comment 4 2012-07-26 06:18:18 PDT
All reviewed patches have been landed. Closing bug.
Yury Semikhatsky
Comment 5 2012-07-26 07:51:11 PDT
Reopening since the patch was reverted in http://trac.webkit.org/changeset/123744 due to AppleMac linker failure: http://build.webkit.org/builders/Apple%20Lion%20Release%20%28Build%29/builds/1706/steps/compile-webkit/logs/stdio
Build Bot
Comment 6 2012-07-26 20:37:30 PDT
Comment on attachment 154601 [details] Patch Attachment 154601 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13373145
Yury Semikhatsky
Comment 7 2012-07-30 01:09:43 PDT
Created attachment 155228 [details] Patch for landing Added WTF_EXPORT_PRIVATE modifier to StringImpl::sizeInBytes method.
Yury Semikhatsky
Comment 8 2012-07-30 02:05:36 PDT
Committed r124006: <http://trac.webkit.org/changeset/124006>
Note You need to log in before you can comment on or make changes to this bug.