Bug 93262

Summary: [WK2][GTK] Improvements for the new spell-checking API
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, mrobinson, webkit.review.bot
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 90268    
Bug Blocks:    
Attachments:
Description Flags
Patch proposal cgarcia: review+

Mario Sanchez Prada
Reported 2012-08-06 05:57:13 PDT
As you can see from Carlos's last comment on bug 90268 [1], it seems like I was too fast pushing that patch and that some improvements could still have happened over the last iteration of the patch. So, this bug is just for tracking down those improvements, now that bug 90268 has already been resolved. [1] https://bugs.webkit.org/show_bug.cgi?id=90268#c25
Attachments
Patch proposal (18.68 KB, patch)
2012-08-06 06:23 PDT, Mario Sanchez Prada 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1 2012-08-06 06:23:07 PDT
Created attachment 156680 [details] Patch proposal Patch addressing the issues pointed out by Carlos in https://bugs.webkit.org/show_bug.cgi?id=90268#c25
WebKit Review Bot
Comment 2 2012-08-06 06:27:18 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2012-08-06 06:33:49 PDT
Comment on attachment 156680 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=156680&action=review Please, check the comments I made here before landing, thanks! > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:485 > + if (!spellCheckingLanguages.length()) Use spellCheckingLanguages.isNull() instead. > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:517 > + context->priv->textChecker->setSpellCheckingLanguages(CString(languages)); A char* can be assigned to a CString, so I'm not sure, but I think you can pass the languages directly here: context->priv->textChecker->setSpellCheckingLanguages(languages);
Mario Sanchez Prada
Comment 4 2012-08-06 06:43:27 PDT
Committed r124763: <http://trac.webkit.org/changeset/124763>
Note You need to log in before you can comment on or make changes to this bug.