Bug 94397

Summary: Web Inspector: expose object internal properties such as PrimitiveValue or BoundThis
Product: WebKit Reporter: Peter Rybin <prybin>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, dglazkov, gustavo, haraken, japhet, joepeck, keishi, loislo, pfeldman, philn, pmuellr, rik, timothy, webkit.review.bot, xan.lopez, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Peter Rybin
Reported 2012-08-17 16:57:48 PDT
Some JavaScript objects holds inner state that cannot be seen as a regular properties. However the state is well defined in spec as internal properties. Make them visible to user, since they might be important for user data exploring.
Attachments
Patch (7.58 KB, patch)
2012-08-17 17:36 PDT, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Patch (7.57 KB, patch)
2012-08-17 17:44 PDT, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Patch (7.57 KB, patch)
2012-08-17 18:02 PDT, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Patch (9.04 KB, patch)
2012-09-21 10:51 PDT, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Patch (23.84 KB, patch)
2012-09-25 12:22 PDT, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Patch (24.83 KB, patch)
2012-10-03 14:19 PDT, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Patch (25.52 KB, patch)
2012-10-03 15:20 PDT, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Peter Rybin
Comment 1 2012-08-17 17:36:24 PDT
Created attachment 159242 [details] Patch
Peter Rybin
Comment 2 2012-08-17 17:44:46 PDT
Created attachment 159243 [details] Patch
WebKit Review Bot
Comment 3 2012-08-17 17:54:14 PDT
Comment on attachment 159243 [details] Patch Attachment 159243 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13520603
Peter Rybin
Comment 4 2012-08-17 18:02:21 PDT
Created attachment 159248 [details] Patch
Build Bot
Comment 5 2012-08-17 18:49:12 PDT
Comment on attachment 159248 [details] Patch Attachment 159248 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13517960
Timothy Hatcher
Comment 6 2012-08-17 19:04:41 PDT
Comment on attachment 159248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159248&action=review > Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp:194 > + return jsUndefined(); Please file a JSC bug about adding this and put in a FIXME.
Peter Rybin
Comment 7 2012-09-21 10:51:28 PDT
Created attachment 165154 [details] Patch
Build Bot
Comment 8 2012-09-21 11:12:45 PDT
Comment on attachment 165154 [details] Patch Attachment 165154 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13951777 New failing tests: inspector/console/command-line-api.html
WebKit Review Bot
Comment 9 2012-09-21 13:46:12 PDT
Comment on attachment 165154 [details] Patch Attachment 165154 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13980006 New failing tests: WebFilterOperationsTest.saveAndRestore inspector/console/command-line-api.html
Yury Semikhatsky
Comment 10 2012-09-24 06:50:08 PDT
Comment on attachment 165154 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165154&action=review > Source/WebCore/inspector/Inspector.json:498 > + { "name": "internal", "type": "boolean", "optional": true, "description": "True if property is only visible in debugger and its name is conventional." } r- for this part as we agreed off the bug to return internal properties in a separate array instead.
Peter Rybin
Comment 11 2012-09-25 12:22:49 PDT
Created attachment 165655 [details] Patch
WebKit Review Bot
Comment 12 2012-09-25 12:25:04 PDT
Attachment 165655 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1 Source/WebCore/inspector/InjectedScript.cpp:145: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InjectedScript.h:82: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Peter Rybin
Comment 13 2012-09-25 12:26:04 PDT
(In reply to comment #11) > Created an attachment (id=165655) [details] > Patch Since this patch this bug assumes that frontend needs explicit support for this feature (with previous version it got internal properties among others).
Build Bot
Comment 14 2012-09-25 12:48:32 PDT
Comment on attachment 165655 [details] Patch Attachment 165655 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14019240
Build Bot
Comment 15 2012-09-25 14:08:37 PDT
Comment on attachment 165655 [details] Patch Attachment 165655 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14032197 New failing tests: inspector-protocol/runtime-getProperties.html http/tests/security/sandboxed-iframe-origin-add.html
Yury Semikhatsky
Comment 16 2012-09-25 23:02:57 PDT
Comment on attachment 165655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165655&action=review > LayoutTests/inspector-protocol/runtime-getProperties-expected.txt:1 > +Properties of Object(5) You will also need to provide JSC-specific test expectations. > LayoutTests/inspector-protocol/runtime-getProperties.html:50 > + processStep(next); Consider moving this into the try block. > LayoutTests/inspector-protocol/runtime-getProperties.html:90 > + if (id === undefined) if (!id) would work
Peter Rybin
Comment 17 2012-09-26 07:00:58 PDT
Comment on attachment 165655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165655&action=review >> LayoutTests/inspector-protocol/runtime-getProperties.html:50 >> + processStep(next); > > Consider moving this into the try block. processStep is a one big try itself. >> LayoutTests/inspector-protocol/runtime-getProperties.html:90 >> + if (id === undefined) > > if (!id) would work Technically yes, but I'd like not think about whether id can legitimately 0 (no) or empty string (no).
Peter Rybin
Comment 18 2012-10-03 14:19:11 PDT
Created attachment 166959 [details] Patch
WebKit Review Bot
Comment 19 2012-10-03 14:22:07 PDT
Attachment 166959 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1 Source/WebCore/inspector/InjectedScript.cpp:145: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InjectedScript.h:82: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 20 2012-10-03 15:04:36 PDT
Comment on attachment 166959 [details] Patch Attachment 166959 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14131786 New failing tests: inspector/console/command-line-api.html
Peter Rybin
Comment 21 2012-10-03 15:20:40 PDT
Created attachment 166970 [details] Patch
WebKit Review Bot
Comment 22 2012-10-03 15:26:42 PDT
Attachment 166970 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1 Source/WebCore/inspector/InjectedScript.cpp:145: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InjectedScript.h:82: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Peter Rybin
Comment 23 2012-10-04 08:26:59 PDT
(In reply to comment #16) > (From update of attachment 165655 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165655&action=review > > > LayoutTests/inspector-protocol/runtime-getProperties-expected.txt:1 > > +Properties of Object(5) > > You will also need to provide JSC-specific test expectations. Done
WebKit Review Bot
Comment 24 2012-10-04 09:12:34 PDT
Comment on attachment 166970 [details] Patch Clearing flags on attachment: 166970 Committed r130398: <http://trac.webkit.org/changeset/130398>
WebKit Review Bot
Comment 25 2012-10-04 09:12:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.