Bug 97877

Summary: [Forms] Multiple fields week input UI
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, macpherson, menard, mifenton, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 97992, 98104, 100128, 102045    
Bug Blocks: 29359, 98006    
Attachments:
Description Flags
Patch 1
none
Patch 2
none
Patch 3 none

yosin
Reported 2012-09-28 02:46:09 PDT
Chromium port wants to have multiple fields week input UI like multiple fields time input UI.
Attachments
Patch 1 (11.02 KB, patch)
2012-10-01 02:30 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (10.92 KB, patch)
2012-10-01 02:45 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 3 (10.93 KB, patch)
2012-10-01 03:14 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-10-01 02:30:52 PDT
Created attachment 166432 [details] Patch 1
yosin
Comment 2 2012-10-01 02:31:28 PDT
Comment on attachment 166432 [details] Patch 1 Could you review this patch? Thanks in advance.
Kent Tamura
Comment 3 2012-10-01 02:41:02 PDT
Comment on attachment 166432 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=166432&action=review > Source/WebCore/html/WeekInputType.cpp:45 > +#include "Localizer.h" Is this needed?
yosin
Comment 4 2012-10-01 02:45:36 PDT
Created attachment 166434 [details] Patch 2
yosin
Comment 5 2012-10-01 02:46:28 PDT
Comment on attachment 166434 [details] Patch 2 Could you review this patch? Thanks in advance. = Changes since the last review = * Remove unused include file Localizer.h from WeekInputType.cpp
Kent Tamura
Comment 6 2012-10-01 03:00:23 PDT
Comment on attachment 166434 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=166434&action=review ok except ChangeLog > Source/WebCore/ChangeLog:19 > + - fast/forms/month/month-stepup-stepdown-from-renderer.html fast/forms/week/week-...
yosin
Comment 7 2012-10-01 03:14:13 PDT
Created attachment 166439 [details] Patch 3
yosin
Comment 8 2012-10-01 03:23:04 PDT
Comment on attachment 166439 [details] Patch 3 Clearing flags on attachment: 166439 Committed r130024: <http://trac.webkit.org/changeset/130024>
yosin
Comment 9 2012-10-01 03:23:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.