Bug 98134

Summary: [Refactoring] StyleResolver::matchScopedAuthorRules() could be simpler
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: CSSAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, macpherson, menard, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 97279    
Attachments:
Description Flags
Patch
none
Patch for landing none

Hajime Morrita
Reported 2012-10-02 03:20:10 PDT
This is simple refactoring for preparation around style scope related changes.
Attachments
Patch (3.77 KB, patch)
2012-10-02 03:28 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.88 KB, patch)
2012-10-02 21:49 PDT, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-10-02 03:28:03 PDT
Created attachment 166653 [details] Patch
Hajime Morrita
Comment 2 2012-10-02 03:28:24 PDT
Dimitri, Sakamoto-san, could you take a look?
Build Bot
Comment 3 2012-10-02 05:55:54 PDT
Comment on attachment 166653 [details] Patch Attachment 166653 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14131254 New failing tests: http/tests/workers/terminate-during-sync-operation.html
Dimitri Glazkov (Google)
Comment 4 2012-10-02 09:16:16 PDT
Comment on attachment 166653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166653&action=review ok. > Source/WebCore/css/StyleResolver.cpp:977 > + if (documentScope ? !applyAuthorStyles : frame.m_authorStyleBoundsIndex != m_scopeStackParentBoundsIndex) This is getting too terse :)
Hajime Morrita
Comment 5 2012-10-02 21:47:47 PDT
Comment on attachment 166653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166653&action=review Hi Dimitri, Thanks for taking a look! I'll land this after small tweak. >> Source/WebCore/css/StyleResolver.cpp:977 >> + if (documentScope ? !applyAuthorStyles : frame.m_authorStyleBoundsIndex != m_scopeStackParentBoundsIndex) > > This is getting too terse :) Well, will relax a bit more :-)
Hajime Morrita
Comment 6 2012-10-02 21:49:17 PDT
Created attachment 166806 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-10-02 22:25:57 PDT
Comment on attachment 166806 [details] Patch for landing Clearing flags on attachment: 166806 Committed r130249: <http://trac.webkit.org/changeset/130249>
WebKit Review Bot
Comment 8 2012-10-02 22:26:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.