Bug 99750

Summary: [Shadow]: Fallback content should also be reprojected
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, macpherson, menard, shinyak, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 99815    
Bug Blocks: 96986    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Dimitri Glazkov (Google)
Reported 2012-10-18 13:23:37 PDT
See https://www.w3.org/Bugs/Public/show_bug.cgi?id=19436
Attachments
Patch (12.21 KB, patch)
2012-10-22 03:30 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (11.28 KB, patch)
2012-10-22 19:21 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.28 KB, patch)
2012-10-22 19:43 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-10-18 20:38:38 PDT
I'll take a look. I think it is working in the current implementation, but let's have a test to confirm it.
Shinya Kawanaka
Comment 2 2012-10-18 22:42:22 PDT
Ah... It hits ASSERT!
Shinya Kawanaka
Comment 3 2012-10-18 23:28:04 PDT
Even after fixing ASSERT, fallback content is not rendered. Maybe we have to fix ParentWalker.
Shinya Kawanaka
Comment 4 2012-10-19 01:00:36 PDT
- host - content - div (fallback) We have assumed that only direct children of the host can be distributed, but it's wrong!
Shinya Kawanaka
Comment 5 2012-10-19 01:28:25 PDT
I'm now working for this.
Shinya Kawanaka
Comment 6 2012-10-22 03:30:34 PDT
Created attachment 169869 [details] Patch
Dimitri Glazkov (Google)
Comment 7 2012-10-22 15:16:46 PDT
Comment on attachment 169869 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169869&action=review > Source/WebCore/html/shadow/HTMLContentElement.h:65 > +inline HTMLContentElement* toHTMLContentElement(Node* node) Is this used anywhere? > Source/WebCore/html/shadow/InsertionPoint.h:123 > +inline Node* parentNodeForDistribution(const Node* node) Why is this hanging in the InsertionPoint? And why are the two methods? Can't this just be an inline static helper inside of the ComposedShadowTreeWalker? It seems like you are prematurely building an API when there's only one consumer of this function.
Shinya Kawanaka
Comment 8 2012-10-22 19:05:36 PDT
Comment on attachment 169869 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169869&action=review >> Source/WebCore/html/shadow/InsertionPoint.h:123 >> +inline Node* parentNodeForDistribution(const Node* node) > > Why is this hanging in the InsertionPoint? And why are the two methods? Can't this just be an inline static helper inside of the ComposedShadowTreeWalker? It seems like you are prematurely building an API when there's only one consumer of this function. Actually we also need this in StyleResolver. We should have only one, though.
Shinya Kawanaka
Comment 9 2012-10-22 19:21:15 PDT
Created attachment 170043 [details] Patch
Dimitri Glazkov (Google)
Comment 10 2012-10-22 19:36:12 PDT
Comment on attachment 170043 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170043&action=review > Source/WebCore/html/shadow/InsertionPoint.h:123 > +static inline Element* parentElementForDistribution(const Node* node) I don't know if "static" makes any sense in this context.
Shinya Kawanaka
Comment 11 2012-10-22 19:43:45 PDT
Created attachment 170049 [details] Patch for landing
Shinya Kawanaka
Comment 12 2012-10-22 19:44:22 PDT
(In reply to comment #10) > (From update of attachment 170043 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170043&action=review > > > Source/WebCore/html/shadow/InsertionPoint.h:123 > > +static inline Element* parentElementForDistribution(const Node* node) > > I don't know if "static" makes any sense in this context. It's a mistake! Removed.
WebKit Review Bot
Comment 13 2012-10-22 20:08:56 PDT
Comment on attachment 170049 [details] Patch for landing Clearing flags on attachment: 170049 Committed r132174: <http://trac.webkit.org/changeset/132174>
WebKit Review Bot
Comment 14 2012-10-22 20:09:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.