WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
240900
Consider not generating a full commit message on each commit before squashing
https://bugs.webkit.org/show_bug.cgi?id=240900
Summary
Consider not generating a full commit message on each commit before squashing
Manuel Rego Casasnovas
Reported
2022-05-24 22:33:16 PDT
Maybe this is just me, but when I work on a patch, I usually have a local branch where I do a lot of small commits. For these commits I use simple "one liner" commit messages. Once I have something useful for sending to review, then I squash these commits together, and write a proper commit message and the like. The problem I see with the new GitHub workflow, is that every local commit, is running the pre-commit hook, and generating a very big commit messsage. I found a way to skip that with "git commit -m" but I wonder if this is the right default or not. When I'm running "git-webkit upload" then I'd be happy to be asked to provide a good commit message and all that, but before that it seems like noise to my way of working. WDYT?
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-05-31 22:34:13 PDT
<
rdar://problem/94200445
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug