RESOLVED FIXED 49094
run platform/chromium/plugins/nested-plugin-objects.html on all platforms 
https://bugs.webkit.org/show_bug.cgi?id=49094
Summary run platform/chromium/plugins/nested-plugin-objects.html on all platforms
Tony Chang
Reported 2010-11-05 14:24:57 PDT
run platform/chromium/plugins/nested-plugin-objects.html on all platforms
Attachments
Patch (7.43 KB, patch)
2010-11-05 14:28 PDT, Tony Chang 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-11-05 14:28:09 PDT
Created attachment 73119 [details] Patch
Tony Chang
Comment 2 2010-11-05 14:30:17 PDT
Moving another test from platform/chromium/plugins into plugins and copying some code from the chromium forked plugin upstream. This needs to be landed by hand to get the file move.
Adam Barth
Comment 3 2010-11-05 22:04:45 PDT
Comment on attachment 73119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73119&action=review > WebKitTools/DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:118 > + if (testObject->testObject) > + browser->releaseobject(testObject->testObject); Four-space indent. > WebKitTools/DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:167 > + if (!testObject->testObject) > + testObject->testObject = browser->createobject(0, &testClass); four-space indent
Tony Chang
Comment 4 2010-11-08 09:57:00 PST
Committed r71537: <http://trac.webkit.org/changeset/71537>
Eric Seidel (no email)
Comment 5 2010-11-08 10:49:31 PST
SUCCESS: Build 20478 (r71539) was the first to show failures: set([u'plugins/nested-plugin-objects.html']) This is broken on Snow Leopard it seems.
Tony Chang
Comment 6 2010-11-08 11:17:30 PST
(In reply to comment #5) > SUCCESS: Build 20478 (r71539) was the first to show failures: set([u'plugins/nested-plugin-objects.html']) > > This is broken on Snow Leopard it seems. Sorry, fixing...
WebKit Review Bot
Comment 7 2010-11-08 11:45:03 PST
http://trac.webkit.org/changeset/71537 might have broken Qt Linux Release
Note You need to log in before you can comment on or make changes to this bug.