Created attachment 94746 [details] Patch

Changes LGTM. Please be a bit more specific in the first paragraphs of the changelog. You mention all changes in the file list, but it's nice to have the important bit at the top ("Fixed a couple issues: * Use runtime checks instead of compile time checks * If smooth scrolling isn't active, tell the system to not use it * use new knob api") Speaking of the smooth scrolling change: If it fixes the paint artifacts, it's ok for now, but in general we want to use system-provided smooth scrolling on mac. the SMOOTH_SCROLLING define toggles logic _in webcore_ that controls smooth scrolling, for platforms that don't have this natively (e.g. chromium/windows). We never want that on mac.

> the SMOOTH_SCROLLING define toggles logic _in webcore_ that controls smooth scrolling, for platforms that don't have this natively (e.g. chromium/windows). We never want that on mac. Sorry, I didn't really understand this. You mean that we want ENABLE(SMOOTH_SCROLLING) always to be false, right? Before my addition of ScrollAnimatorChromiumMac we used ScrollAnimator::scroll() for scroll events. With this change we go back to using that. That's correct right? This change doesn't fix repaint artifacts for me. It just disables smooth scrolling (back to the way it was before my change). Thanks

> Before my addition of ScrollAnimatorChromiumMac we used ScrollAnimator::scroll() for scroll events. With this change we go back to using that. > > That's correct right? Ah, yes.

You may want to rebase this patch. If EWSes didn't like it, I am pretty sure cq won't be able to land it.

Comment on attachment 94746 [details] Patch k

This change got rolled into http://trac.webkit.org/changeset/88396