RESOLVED WONTFIX63337
convert editing/deleting/smart-delete-001/002 to runEditingDumpAsText
https://bugs.webkit.org/show_bug.cgi?id=63337
Summary convert editing/deleting/smart-delete-001/002 to runEditingDumpAsText
Wyatt Carss
Reported 2011-06-24 11:22:25 PDT
convert editing/deleting/smart-delete-001/002 to runEditingDumpAsText
Attachments
Patch (215.96 KB, patch)
2011-06-24 11:30 PDT, Wyatt Carss
eric: review+
webkit.review.bot: commit-queue-
Wyatt Carss
Comment 1 2011-06-24 11:30:28 PDT
Wyatt Carss
Comment 2 2011-06-24 11:36:02 PDT
I need to gather a qt rebaseline from the bots for editing/deleting/smart-delete-002.html because I wasn't confident enough in converting the delegate output from cr-linux for it, but I believe that the other tests should pass. If they don't, I can rebaseline with them.
Eric Seidel (no email)
Comment 3 2011-09-12 15:49:02 PDT
Comment on attachment 98517 [details] Patch LGTM.
WebKit Review Bot
Comment 4 2011-09-12 20:12:44 PDT
Comment on attachment 98517 [details] Patch Rejecting attachment 98517 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ing/smart-delete-002-expected.txt Hunk #1 FAILED at 1. File LayoutTests/platform/qt/editing/deleting/smart-delete-002-expected.txt is not empty after patch, as expected 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/editing/deleting/smart-delete-002-expected.txt.rej rm 'LayoutTests/platform/qt/editing/deleting/smart-delete-002-expected.txt' Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/9651012
Wyatt Carss
Comment 5 2011-09-13 08:55:42 PDT
I should have resolved this as won't fix; rniwa suggested that this might not be a good test to convert because it has distinct editing delegates on a few different platforms (particularly qt). The test also might have changed since I wrote the conversion in June. Sorry to leave the cruft!
Note You need to log in before you can comment on or make changes to this bug.